Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add codecov #2328

Merged
merged 1 commit into from
Sep 6, 2023
Merged

🌱 Add codecov #2328

merged 1 commit into from
Sep 6, 2023
+73 −0

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Sep 6, 2023 •
edited
Loading

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
Add codecov to keep an overview over our test coverage

(mostly copied from CAPZ)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #2308

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 6, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 6, 2023
@sbueringer
Copy link
Member Author

/hold
Still trying it out locally, playing a bit around with it

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2023
sbueringer
sbueringer commented Sep 6, 2023
View reviewed changes
.github/codecov.yml
@@ -0,0 +1,12 @@
coverage:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation: https://docs.codecov.com/docs/commit-status

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 1% is fine given we use informational

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@31b8129). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2328   +/-   ##
=======================================
  Coverage        ?   50.29%           
=======================================
  Files           ?       87           
  Lines           ?     8028           
  Branches        ?        0           
=======================================
  Hits            ?     4038           
  Misses          ?     3664           
  Partials        ?      326

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbueringer
Add codecov
04d22ef 
Signed-off-by: Stefan Büringer [email protected]
killianmuldoon
killianmuldoon reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Happy to merge this and see how happy we are with the noise over time.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 00ca5c920bf8d4c45dccbed17e85a9e4cf154855

@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2023
@chrischdi
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit c8ca8b8 into kubernetes-sigs:main Sep 6, 2023
17 of 18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Sep 6, 2023
@sbueringer sbueringer deleted the pr-add-codecov branch September 6, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

@zhanggbj zhanggbj Awaiting requested review from zhanggbj

Assignees

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
5 participants
@sbueringer @codecov-commenter @k8s-ci-robot @chrischdi @killianmuldoon